Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48279CB10 for ; Mon, 24 Nov 2014 04:04:13 +0000 (UTC) Received: (qmail 3530 invoked by uid 500); 24 Nov 2014 04:04:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3449 invoked by uid 500); 24 Nov 2014 04:04:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3438 invoked by uid 500); 24 Nov 2014 04:04:12 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 3435 invoked by uid 99); 24 Nov 2014 04:04:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 04:04:12 +0000 Date: Mon, 24 Nov 2014 04:04:12 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HIVE-8952) Exception handling should be improved in DataWritableWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Brock Noland created HIVE-8952: ---------------------------------- Summary: Exception handling should be improved in DataWritableWriter Key: HIVE-8952 URL: https://issues.apache.org/jira/browse/HIVE-8952 Project: Hive Issue Type: Bug Reporter: Brock Noland 1) In the {{write(final ArrayWritable record)}} method we should be logging the stack trace as well as the message. 2) We should be passing the caught exception into the arguments of the RuntimeException 3) Instead of throwing RuntimeException we should throw IllegalArgumentException since it gives some additional semantics (i.e. the argument to this method was the problem) -- This message was sent by Atlassian JIRA (v6.3.4#6332)