Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3ACCC1074E for ; Mon, 17 Nov 2014 23:31:35 +0000 (UTC) Received: (qmail 57254 invoked by uid 500); 17 Nov 2014 23:31:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 57186 invoked by uid 500); 17 Nov 2014 23:31:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 57102 invoked by uid 500); 17 Nov 2014 23:31:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 57067 invoked by uid 99); 17 Nov 2014 23:31:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2014 23:31:34 +0000 Date: Mon, 17 Nov 2014 23:31:34 +0000 (UTC) From: "Hari Sankar Sivarama Subramaniyan (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HIVE-8786) ObjectStore.rollbackTransaction() should decrement openTrasactionCalls and not set it to 0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Sankar Sivarama Subramaniyan resolved HIVE-8786. ----------------------------------------------------- Resolution: Not a Problem > ObjectStore.rollbackTransaction() should decrement openTrasactionCalls and not set it to 0 > ------------------------------------------------------------------------------------------- > > Key: HIVE-8786 > URL: https://issues.apache.org/jira/browse/HIVE-8786 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-8786.1.patch > > > In ObjectStore.java, > {noformat} > public void rollbackTransaction() { > if (openTrasactionCalls < 1) { > debugLog("rolling back transaction: no open transactions: " + openTrasactionCalls); > return; > } > openTrasactionCalls = 0; > {noformat} > I think the above code should be changes to openTrasactionCalls--; instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)