Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D7701021E for ; Sat, 1 Nov 2014 22:17:37 +0000 (UTC) Received: (qmail 41035 invoked by uid 500); 1 Nov 2014 22:17:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 40920 invoked by uid 500); 1 Nov 2014 22:17:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 40703 invoked by uid 500); 1 Nov 2014 22:17:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 40621 invoked by uid 99); 1 Nov 2014 22:17:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Nov 2014 22:17:34 +0000 Date: Sat, 1 Nov 2014 22:17:34 +0000 (UTC) From: "Prasanth J (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-8689) handle overflows in statistics better MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193522#comment-14193522 ] Prasanth J commented on HIVE-8689: ---------------------------------- [~sershe] minor nit: Can you remove the getMaxIfOverflow() method? Since we are using safeAdd, safeMultiply methods we don't need that anymore. > handle overflows in statistics better > ------------------------------------- > > Key: HIVE-8689 > URL: https://issues.apache.org/jira/browse/HIVE-8689 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Fix For: 0.14.0 > > Attachments: HIVE-8689.01.patch, HIVE-8689.02.patch, HIVE-8689.patch > > > Improve overflow checks in StatsAnnotation optimizer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)