Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02CB6F411 for ; Thu, 13 Nov 2014 06:41:35 +0000 (UTC) Received: (qmail 2564 invoked by uid 500); 13 Nov 2014 06:41:34 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 2504 invoked by uid 500); 13 Nov 2014 06:41:34 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 2485 invoked by uid 500); 13 Nov 2014 06:41:34 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 2458 invoked by uid 99); 13 Nov 2014 06:41:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Nov 2014 06:41:34 +0000 Date: Thu, 13 Nov 2014 06:41:34 +0000 (UTC) From: "JongWon Park (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-8284) Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209379#comment-14209379 ] JongWon Park commented on HIVE-8284: ------------------------------------ Thanks, Ashutosh! > Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys() > ------------------------------------------------------------------------------------------------------- > > Key: HIVE-8284 > URL: https://issues.apache.org/jira/browse/HIVE-8284 > Project: Hive > Issue Type: Bug > Components: CBO > Affects Versions: 0.14.0 > Reporter: Ted Yu > Assignee: JongWon Park > Priority: Minor > Fix For: 0.15.0 > > Attachments: HIVE-8284.patch > > > {code} > double numRows = tScan.getRows(); > ... > double r = cStat.getRange().maxValue.doubleValue() - > cStat.getRange().minValue.doubleValue() + 1; > isKey = (numRows == r); > {code} > The equality check should use a small epsilon as tolerance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)