Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED1D8104EA for ; Mon, 24 Nov 2014 18:17:29 +0000 (UTC) Received: (qmail 16758 invoked by uid 500); 24 Nov 2014 18:17:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 16684 invoked by uid 500); 24 Nov 2014 18:17:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 16671 invoked by uid 99); 24 Nov 2014 18:17:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Nov 2014 18:17:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1C6D667CD5; Mon, 24 Nov 2014 18:17:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1097864831431957052==" MIME-Version: 1.0 Subject: Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe From: "Brock Noland" To: "cheng xu" , "hive" , "Brock Noland" Date: Mon, 24 Nov 2014 18:17:28 -0000 Message-ID: <20141124181728.15978.53676@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/28147/ X-Sender: "Brock Noland" References: <20141124041633.15978.75667@reviews.apache.org> In-Reply-To: <20141124041633.15978.75667@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============1097864831431957052== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28147/#review62822 ----------------------------------------------------------- LGTM! One comment below. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java What's the purpose of Binary.fromByteArray(binaryBytes).getBytes() in this line? Doesn't it just end up returning the byte array? - Brock Noland On Nov. 24, 2014, 4:16 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28147/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 4:16 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This patch includes: > 1. binary support for ParquetHiveSerde > 2. related test cases both in unit and ql test > > > Diffs > ----- > > data/files/parquet_types.txt d342062 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java 472de8f > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java d5aae3b > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java 4effe73 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 8ac7864 > ql/src/test/queries/clientpositive/parquet_types.q 22585c3 > ql/src/test/results/clientpositive/parquet_types.q.out 275897c > > Diff: https://reviews.apache.org/r/28147/diff/ > > > Testing > ------- > > related UT and QL tests passed > > > Thanks, > > cheng xu > > --===============1097864831431957052==--