Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3B48109D4 for ; Mon, 17 Nov 2014 19:50:29 +0000 (UTC) Received: (qmail 62621 invoked by uid 500); 17 Nov 2014 19:50:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 62556 invoked by uid 500); 17 Nov 2014 19:50:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 62543 invoked by uid 99); 17 Nov 2014 19:50:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2014 19:50:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 843D911674E; Mon, 17 Nov 2014 19:50:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6975983051829602840==" MIME-Version: 1.0 Subject: Re: Review Request 27566: HIVE-8609: move beeline to jline2 From: "Mohit Sabharwal" To: "cheng xu" , "Mohit Sabharwal" , "hive" Date: Mon, 17 Nov 2014 19:50:28 -0000 Message-ID: <20141117195028.24717.25547@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mohit Sabharwal" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27566/ X-Sender: "Mohit Sabharwal" References: <20141113162903.9703.7869@reviews.apache.org> In-Reply-To: <20141113162903.9703.7869@reviews.apache.org> Reply-To: "Mohit Sabharwal" X-ReviewRequest-Repository: hive-git --===============6975983051829602840== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review61777 ----------------------------------------------------------- Ship it! LICENSE Please remove the word "contains". It's not part of the license. beeline/src/java/org/apache/hive/beeline/BeeLine.java move import up in jline section - Mohit Sabharwal On Nov. 13, 2014, 4:29 p.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27566/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 4:29 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-8609: move beeline to jline2 > The following will be changed: > * MultiCompletor-> AggregateCompleter > * SimpleCompletor->StringsCompleter > * Terminal.getTerminalWidth() -> Terminal.getWidth() > * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal > * String -> CharSequence > > > Diffs > ----- > > LICENSE 2885945 > beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 > beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 > beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 > beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 > beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 > beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 > beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 > beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae > beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 > hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 > pom.xml ec8c4fe > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 > > Diff: https://reviews.apache.org/r/27566/diff/ > > > Testing > ------- > > > Thanks, > > cheng xu > > --===============6975983051829602840==--