Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF686C739 for ; Sat, 15 Nov 2014 16:53:52 +0000 (UTC) Received: (qmail 51763 invoked by uid 500); 15 Nov 2014 16:53:51 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 51692 invoked by uid 500); 15 Nov 2014 16:53:51 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 51678 invoked by uid 99); 15 Nov 2014 16:53:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Nov 2014 16:53:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A6599260CBF; Sat, 15 Nov 2014 16:53:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7032084275677622853==" MIME-Version: 1.0 Subject: Re: Review Request 28064: HIVE-8844 Choose a persisent policy for RDD caching [Spark Branch] From: "Jimmy Xiang" To: "Xuefu Zhang" Cc: "Jimmy Xiang" , "Xuefu Zhang" , "hive" Date: Sat, 15 Nov 2014 16:53:50 -0000 Message-ID: <20141115165350.1251.68397@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jimmy Xiang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/28064/ X-Sender: "Jimmy Xiang" References: <20141115102813.1250.12232@reviews.apache.org> In-Reply-To: <20141115102813.1250.12232@reviews.apache.org> Reply-To: "Jimmy Xiang" X-ReviewRequest-Repository: hive-git --===============7032084275677622853== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 15, 2014, 10:28 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java, line 154 > > > > > > I don't think we need to make this configurable. I think changing cache() to persiste(meory_and_disk) is good enough for now. Let's keep it simple. Sure, no problem. Will do that. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28064/#review61642 ----------------------------------------------------------- On Nov. 15, 2014, 3:14 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28064/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 3:14 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8844 > https://issues.apache.org/jira/browse/HIVE-8844 > > > Repository: hive-git > > > Description > ------- > > Changed spark cache policy to be configurable with default memory+disk. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java 79baea7 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java 8565ba0 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 11f4236 > > Diff: https://reviews.apache.org/r/28064/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > > --===============7032084275677622853==--