Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0610717D82 for ; Sun, 9 Nov 2014 05:20:37 +0000 (UTC) Received: (qmail 68032 invoked by uid 500); 9 Nov 2014 05:20:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 67963 invoked by uid 500); 9 Nov 2014 05:20:36 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 67950 invoked by uid 99); 9 Nov 2014 05:20:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 09 Nov 2014 05:20:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CC2971DFD5D; Sun, 9 Nov 2014 05:20:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6828844642462142379==" MIME-Version: 1.0 Subject: Re: Review Request 27627: Split map-join plan into 2 SparkTasks in 3 stages [Spark Branch] From: "Chao Sun" To: "Szehon Ho" , "hive" , "Chao Sun" Date: Sun, 09 Nov 2014 05:20:39 -0000 Message-ID: <20141109052039.10454.76830@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27627/ X-Sender: "Chao Sun" References: <20141108004420.10454.71650@reviews.apache.org> In-Reply-To: <20141108004420.10454.71650@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============6828844642462142379== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 8, 2014, 12:44 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 224 > > > > > > I've been thinking about this, as you had brought up a pretty rare use-case where a big-table parent of mapjoin1 still had a HTS , but its for another(!) mapjoin. I dont know if this is still a valid case , but do you think this handles it, as it just indisciriminately adds it to the parent map if it has HTS? Fixed through a offline chat. - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27627/#review60380 ----------------------------------------------------------- On Nov. 7, 2014, 6:07 p.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27627/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 6:07 p.m.) > > > Review request for hive. > > > Bugs: HIVE-8622 > https://issues.apache.org/jira/browse/HIVE-8622 > > > Repository: hive-git > > > Description > ------- > > This is a sub-task of map-join for spark > https://issues.apache.org/jira/browse/HIVE-7613 > This can use the baseline patch for map-join > https://issues.apache.org/jira/browse/HIVE-8616 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 66fd6b6 > > Diff: https://reviews.apache.org/r/27627/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > > --===============6828844642462142379==--