Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBC4017ABA for ; Fri, 7 Nov 2014 23:07:29 +0000 (UTC) Received: (qmail 78626 invoked by uid 500); 7 Nov 2014 23:07:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 78566 invoked by uid 500); 7 Nov 2014 23:07:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 78553 invoked by uid 99); 7 Nov 2014 23:07:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 23:07:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 350341DFD20; Fri, 7 Nov 2014 23:07:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7720197335098921504==" MIME-Version: 1.0 Subject: Re: Review Request 27627: Split map-join plan into 2 SparkTasks in 3 stages [Spark Branch] From: "Xuefu Zhang" To: "Xuefu Zhang" , "hive" , "Chao Sun" Date: Fri, 07 Nov 2014 23:07:32 -0000 Message-ID: <20141107230732.12275.53207@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27627/ X-Sender: "Xuefu Zhang" References: <20141107180740.12275.73780@reviews.apache.org> In-Reply-To: <20141107180740.12275.73780@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============7720197335098921504== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27627/#review60403 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java Nit: need space before and after -. Same below in multiple occurrances. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java It seems possible that current is MJwork, right? Are you going to add it to the target? ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java Frankly, I'm not 100% following the logic. The diagram has operators mixed with works, which makes it hard. But I'm seeing where you're coming from. Maybe you can explain to me better in person. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java I think there is a separate JIRA handling combining mapjoins, owned by Szehon. - Xuefu Zhang On Nov. 7, 2014, 6:07 p.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27627/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 6:07 p.m.) > > > Review request for hive. > > > Bugs: HIVE-8622 > https://issues.apache.org/jira/browse/HIVE-8622 > > > Repository: hive-git > > > Description > ------- > > This is a sub-task of map-join for spark > https://issues.apache.org/jira/browse/HIVE-7613 > This can use the baseline patch for map-join > https://issues.apache.org/jira/browse/HIVE-8616 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java 66fd6b6 > > Diff: https://reviews.apache.org/r/27627/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > > --===============7720197335098921504==--