Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73FBF17D57 for ; Wed, 5 Nov 2014 21:42:43 +0000 (UTC) Received: (qmail 34730 invoked by uid 500); 5 Nov 2014 21:42:43 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 34665 invoked by uid 500); 5 Nov 2014 21:42:43 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 34647 invoked by uid 99); 5 Nov 2014 21:42:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2014 21:42:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 568D61DFBFC; Wed, 5 Nov 2014 21:42:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7387296684167784537==" MIME-Version: 1.0 Subject: Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch] From: "Chao Sun" To: "Szehon Ho" , "Jimmy Xiang" , "Xuefu Zhang" , "Chao Sun" Cc: "hive" , "Suhas Satish" Date: Wed, 05 Nov 2014 21:42:46 -0000 Message-ID: <20141105214246.10454.37033@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27640/ X-Sender: "Chao Sun" References: <20141105212336.10455.23152@reviews.apache.org> In-Reply-To: <20141105212336.10455.23152@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============7387296684167784537== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 5, 2014, 9:23 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 188 > > > > > > Can you elaborate why we need this assumption? This may not be true in all cases. Actually, we don't need this assumption anymore. I'll remove it. > On Nov. 5, 2014, 9:23 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 141 > > > > > > Please use proper javadoc notation for your javadocs. I didn't use javadoc since it's a private method. Maybe I can write a better description on what it does? - Chao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/#review60031 ----------------------------------------------------------- On Nov. 5, 2014, 8:29 p.m., Suhas Satish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27640/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 8:29 p.m.) > > > Review request for hive, Chao Sun, Jimmy Xiang, Szehon Ho, and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > This replaces ReduceSinks with HashTableSinks in smaller tables for a map-join. But the condition check field to detect map-join is actually being set in CommonJoinResolver, which doesnt exist yet. We need to decide where is the right place to populate this field. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 795a5d7 > > Diff: https://reviews.apache.org/r/27640/diff/ > > > Testing > ------- > > > Thanks, > > Suhas Satish > > --===============7387296684167784537==--