Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E3EA179F9 for ; Wed, 5 Nov 2014 20:29:25 +0000 (UTC) Received: (qmail 84081 invoked by uid 500); 5 Nov 2014 20:29:24 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 84005 invoked by uid 500); 5 Nov 2014 20:29:24 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 83987 invoked by uid 99); 5 Nov 2014 20:29:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2014 20:29:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5F291DFBFB; Wed, 5 Nov 2014 20:29:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0634405119879917806==" MIME-Version: 1.0 Subject: Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch] From: "Suhas Satish" To: "Szehon Ho" , "Jimmy Xiang" , "Xuefu Zhang" , "Chao Sun" Cc: "hive" , "Suhas Satish" Date: Wed, 05 Nov 2014 20:29:27 -0000 Message-ID: <20141105202927.10455.52056@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suhas Satish" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27640/ X-Sender: "Suhas Satish" References: <20141105202914.10454.86412@reviews.apache.org> In-Reply-To: <20141105202914.10454.86412@reviews.apache.org> Reply-To: "Suhas Satish" X-ReviewRequest-Repository: hive-git --===============0634405119879917806== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/ ----------------------------------------------------------- (Updated Nov. 5, 2014, 8:29 p.m.) Review request for hive, Chao Sun, Jimmy Xiang, Szehon Ho, and Xuefu Zhang. Summary (updated) ----------------- HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch] Repository: hive-git Description ------- This replaces ReduceSinks with HashTableSinks in smaller tables for a map-join. But the condition check field to detect map-join is actually being set in CommonJoinResolver, which doesnt exist yet. We need to decide where is the right place to populate this field. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java 795a5d7 Diff: https://reviews.apache.org/r/27640/diff/ Testing ------- Thanks, Suhas Satish --===============0634405119879917806==--