Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89DC11769B for ; Wed, 5 Nov 2014 19:16:52 +0000 (UTC) Received: (qmail 36822 invoked by uid 500); 5 Nov 2014 19:16:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 36749 invoked by uid 500); 5 Nov 2014 19:16:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 36735 invoked by uid 99); 5 Nov 2014 19:16:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2014 19:16:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7D99F1DFBE6; Wed, 5 Nov 2014 19:16:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6811811413512115534==" MIME-Version: 1.0 Subject: Re: Review Request 27627: Split map-join plan into 2 SparkTasks in 3 stages [Spark Branch] From: "Xuefu Zhang" To: "Xuefu Zhang" , "hive" , "Chao Sun" Date: Wed, 05 Nov 2014 19:16:55 -0000 Message-ID: <20141105191655.10454.64116@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27627/ X-Sender: "Xuefu Zhang" References: <20141105175126.10454.85385@reviews.apache.org> In-Reply-To: <20141105175126.10454.85385@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============6811811413512115534== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27627/#review59987 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java Do you mean parentTasks != null? ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java it seems this check should be the first line in the outer for loop, for better efficiency and clarity. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java Merge with itself? - Xuefu Zhang On Nov. 5, 2014, 5:51 p.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27627/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 5:51 p.m.) > > > Review request for hive. > > > Bugs: HIVE-8622 > https://issues.apache.org/jira/browse/HIVE-8622 > > > Repository: hive-git > > > Description > ------- > > This is a sub-task of map-join for spark > https://issues.apache.org/jira/browse/HIVE-7613 > This can use the baseline patch for map-join > https://issues.apache.org/jira/browse/HIVE-8616 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java PRE-CREATION > > Diff: https://reviews.apache.org/r/27627/diff/ > > > Testing > ------- > > > Thanks, > > Chao Sun > > --===============6811811413512115534==--