Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5138E177BC for ; Mon, 3 Nov 2014 11:09:29 +0000 (UTC) Received: (qmail 25559 invoked by uid 500); 3 Nov 2014 11:09:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 25492 invoked by uid 500); 3 Nov 2014 11:09:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 25476 invoked by uid 99); 3 Nov 2014 11:09:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 11:09:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 329901D33D6; Mon, 3 Nov 2014 11:09:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1505515417741488687==" MIME-Version: 1.0 Subject: Re: Review Request 27490: HIVE-8703 More Windows unit test fixes From: "Jason Dere" To: "Thejas Nair" Cc: "Jason Dere" , "hive" Date: Mon, 03 Nov 2014 11:09:31 -0000 Message-ID: <20141103110931.10454.29806@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/27490/ X-Sender: "Jason Dere" References: <20141102190525.10455.19148@reviews.apache.org> In-Reply-To: <20141102190525.10455.19148@reviews.apache.org> Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============1505515417741488687== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27490/ ----------------------------------------------------------- (Updated Nov. 3, 2014, 11:09 a.m.) Review request for hive and Thejas Nair. Changes ------- Fix TestStorageBasedMetastoreAuthorizationDrops. This test fails on Windows because sticky bit doesn't work on Windows filesystem. Change test to use MiniDFS which does support sticky bit. Bugs: HIVE-8703 https://issues.apache.org/jira/browse/HIVE-8703 Repository: hive-git Description ------- - TestStorageBasedMetastoreAuthorizationReads - needs to call WindowsPathUtil.convertPathsFromWindowsToHdfs() - TestAuthorizationApiAuthorizer - created role should have a name. This was causing TestLocationQueries to fail when run together because TestLocationQueries was unable to drop a role with a null name. This one fails on Unix as well. - create_like.q, stats_noscan_2.q: system:hive.root wasn't working on Windows, change test to use system:test.tmp.dir. - Also update the golden files for a few Windows-only .q file tests Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java e65bf4d itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java b59d2e1 itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java dfaa080 ql/src/test/queries/clientpositive/create_like.q eb9f191 ql/src/test/queries/clientpositive/stats_noscan_2.q b106b30 ql/src/test/results/clientpositive/input_part10_win.q.out 92df63c ql/src/test/results/clientpositive/load_dyn_part14_win.q.out 13b6c0b ql/src/test/results/clientpositive/scriptfile1_win.q.out 1f84bd3 Diff: https://reviews.apache.org/r/27490/diff/ Testing ------- Thanks, Jason Dere --===============1505515417741488687==--