hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pankit Thapar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8955) alter partition should check for "hive.stats.autogather" in hiveConf
Date Mon, 24 Nov 2014 23:47:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223778#comment-14223778
] 

Pankit Thapar commented on HIVE-8955:
-------------------------------------

Yes you are correct that the stats are updated in insert overwrite but insert overwrite might
itself call append_partition or alter_partition. In case of append, it respects the flag but
not in case of alter partition.

> alter partition should check for "hive.stats.autogather" in hiveConf
> --------------------------------------------------------------------
>
>                 Key: HIVE-8955
>                 URL: https://issues.apache.org/jira/browse/HIVE-8955
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.13.1
>            Reporter: Pankit Thapar
>             Fix For: 0.15.0
>
>
> When alter partition code path is triggered, it should check for the flag "hive.stats.autogather",
if it is true, then only updateStats else skip them.
> This is done in append_partition code flow. 
> Is there any specific reason the alter_partition does not respect this conf variable?
> //code snippet : HiveMetastore.java 
>  private Partition append_partition_common(RawStore ms, String dbName, String tableName,
>         List<String> part_vals, EnvironmentContext envContext) throws InvalidObjectException,
>         AlreadyExistsException, MetaException {
> ...
> ....
>         if (HiveConf.getBoolVar(hiveConf, HiveConf.ConfVars.HIVESTATSAUTOGATHER) &&
>             !MetaStoreUtils.isView(tbl)) {
>           MetaStoreUtils.updatePartitionStatsFast(part, wh, madeDir);
>         }
> ...
> ...
> }
> The above code snippet checks for the variable but this same check is absent in 
> //code snippet : HiveAlterHandler.java 
> public Partition alterPartition(final RawStore msdb, Warehouse wh, final String dbname,
>       final String name, final List<String> part_vals, final Partition new_part)
>       throws InvalidOperationException, InvalidObjectException, AlreadyExistsException,
>       MetaException {
> ....
> ...
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message