hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8952) Exception handling should be improved in DataWritableWriter
Date Mon, 24 Nov 2014 05:31:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222683#comment-14222683
] 

Brock Noland commented on HIVE-8952:
------------------------------------

Yep, feel free!

> Exception handling should be improved in DataWritableWriter
> -----------------------------------------------------------
>
>                 Key: HIVE-8952
>                 URL: https://issues.apache.org/jira/browse/HIVE-8952
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Brock Noland
>
> 1) In the {{write(final ArrayWritable record)}} method we should be logging the stack
trace as well as the message.
> 2) We should be passing the caught exception into the arguments of the RuntimeException

> 3) Instead of throwing RuntimeException we should throw IllegalArgumentException since
it gives some additional semantics (i.e. the argument to this method was the problem)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message