hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8823) Add additional serde properties for parquet
Date Wed, 12 Nov 2014 22:04:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208787#comment-14208787
] 

Brock Noland commented on HIVE-8823:
------------------------------------

Thank you! I have two review items:

(1) In ParquetSerDe we create new member variables:

{noformat}
private int blockSize;
private boolean enableDictionary;
{noformat}

They are set later on, but never *read*

(2) In ParquetRecordWriterWrapper we call {{ContextUtil.getConfiguration(job)}} multiple times.
We should call it once and re-use the returned reference.

> Add additional serde properties for parquet
> -------------------------------------------
>
>                 Key: HIVE-8823
>                 URL: https://issues.apache.org/jira/browse/HIVE-8823
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Brock Noland
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-8823.1.patch, HIVE-8823.patch
>
>
> Similar to HIVE-7858 and HIVE-8469 I think that users could want to configure {{parquet.enable.dictionary}}
and {{parquet.block.size}} on a per-table basis.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message