hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8794) Hive on Tez leaks AMs when killed before first dag is run
Date Sat, 08 Nov 2014 18:15:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203524#comment-14203524
] 

Gopal V commented on HIVE-8794:
-------------------------------

Don't like it, it is too complicated - the private final + static was sufficient & thread-safe
(because {{<clinit>}} is).

Now this isn't. An easier fix would be to do

{code}
public static void initShutdownHook() {
    Preconditions.checkArgument(shutdownList != null, "Unexpected initialization case for
shutdown sessions list");
}
{code}

This would run the previous code exactly as before, under the JVM class lock, but won't need
any active code within the init calls.

> Hive on Tez leaks AMs when killed before first dag is run
> ---------------------------------------------------------
>
>                 Key: HIVE-8794
>                 URL: https://issues.apache.org/jira/browse/HIVE-8794
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-8794.1.patch
>
>
> The shutdown hook that guards against this kind of leakage is only set up when the TezJobMonitor
class is loaded. If you kill the shell before that - that might be too late.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message