hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8786) ObjectStore.rollbackTransaction() should decrement openTrasactionCalls and not set it to 0
Date Mon, 10 Nov 2014 07:00:47 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204438#comment-14204438
] 

Sergey Shelukhin commented on HIVE-8786:
----------------------------------------

This seems incorrect, transactions are rolled back with all nested transactions. What is the
reason for this change?

> ObjectStore.rollbackTransaction()  should decrement openTrasactionCalls and not set it
to 0
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-8786
>                 URL: https://issues.apache.org/jira/browse/HIVE-8786
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-8786.1.patch
>
>
> In ObjectStore.java,
> {noformat}
>  public void rollbackTransaction() {
>     if (openTrasactionCalls < 1) {
>       debugLog("rolling back transaction: no open transactions: " + openTrasactionCalls);
>       return;
>     }
>     openTrasactionCalls = 0;
> {noformat}
> I think the above code should be changes to openTrasactionCalls--; instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message