hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request 27895: Remove Hadoop 20 shims
Date Tue, 25 Nov 2014 20:04:31 GMT


> On Nov. 25, 2014, 7:23 p.m., Thejas Nair wrote:
> > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java,
line 54
> > <https://reviews.apache.org/r/27895/diff/7/?file=774908#file774908line54>
> >
> >     Is there any reason to keep this here in common-secure and not move it to common
?
> >     Same with other 2 remainging classes in common-secure. Is it just something
that remains to be done ? 
> >     
> >     I am just trying to understand if there is any other reason. I think its OK
to do it in a part 2 jira, this one is already quite big.

No there is no reason to leave it in common-secure. Infact, my goal is to merge common-secure
into common, so after this patch series there will be no common-secure.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27895/#review62947
-----------------------------------------------------------


On Nov. 25, 2014, 2:59 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27895/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2014, 2:59 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-8828
>     https://issues.apache.org/jira/browse/HIVE-8828
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Remove Hadoop 20 shims
> 
> 
> Diffs
> -----
> 
>   beeline/src/test/org/apache/hive/beeline/ProxyAuthTest.java 95146e9 
>   common/src/java/org/apache/hadoop/hive/common/FileUtils.java 95e8d7c 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fafd78e 
>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java ffa648d

>   hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/Security.java 39ef86e

>   itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java 9bf5e1f

>   itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestJdbcWithMiniKdc.java
3e46bed 
>   itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestMiniHiveKdc.java 9d69952

>   itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationProviderWithACL.java
9982195 
>   itests/hive-unit-hadoop2/src/test/java/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java
b2bdafa 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/StorageBasedMetastoreTestBase.java
1d8ac24 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestClientSideAuthorizationProvider.java
f474d83 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java
3bde2fc 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestStorageBasedMetastoreAuthorizationDrops.java
c7b27a6 
>   itests/hive-unit/src/test/java/org/apache/hadoop/hive/thrift/TestZooKeeperTokenStore.java
faa51af 
>   itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 3f47749 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cfac55b 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b137fcb 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java fecae97

>   metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java 0e1fafc

>   metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java ef1eee2

>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c99ce5f 
>   pom.xml b9b27f9 
>   ql/pom.xml fa6c6d9 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42e1e20 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java f834ad5 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 56fd5a0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SecureCmdDoAs.java 832f84f 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/errors/TaskLogProcessor.java 12433ca 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 18e40b3 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d0c022b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 0e326cf 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java e5fce14 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 65a0090 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 260444f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputSplit.java 481deba 
>   ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 35db50c 
>   ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveRecordReader.java 6318b2f 
>   ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java 7d0ca50 
>   ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeFileTask.java 4c2843c 
>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java 75e83b8

>   ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java 51a2cc6

>   ql/src/java/org/apache/hadoop/hive/ql/security/HadoopDefaultAuthenticator.java d68d19d

>   ql/src/java/org/apache/hadoop/hive/ql/security/ProxyUserAuthenticator.java 95a98fe

>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 2806bd1 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionState.java 63687eb 
>   ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table.q 5dda4c0 
>   ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table2.q acc028b 
>   ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table2_h23.q d814304

>   ql/src/test/queries/clientpositive/alter_numbuckets_partitioned_table_h23.q a039925

>   ql/src/test/queries/clientpositive/archive.q a928a81 
>   ql/src/test/queries/clientpositive/archive_corrupt.q cc9801d 
>   ql/src/test/queries/clientpositive/archive_excludeHadoop20.q 90757f2 
>   ql/src/test/queries/clientpositive/auto_join14.q b282fb9 
>   ql/src/test/queries/clientpositive/auto_join14_hadoop20.q 235b7c1 
>   ql/src/test/queries/clientpositive/combine2.q 615986d 
>   ql/src/test/queries/clientpositive/combine2_hadoop20.q 9a9782a 
>   ql/src/test/queries/clientpositive/combine2_win.q f6090bb 
>   ql/src/test/queries/clientpositive/ctas.q 71af40e 
>   ql/src/test/queries/clientpositive/ctas_hadoop20.q f39689d 
>   ql/src/test/queries/clientpositive/groupby_sort_1.q da7c2a2 
>   ql/src/test/queries/clientpositive/groupby_sort_1_23.q 8714653 
>   ql/src/test/queries/clientpositive/groupby_sort_skew_1.q 36c67cf 
>   ql/src/test/queries/clientpositive/groupby_sort_skew_1_23.q 068a675 
>   ql/src/test/queries/clientpositive/input12.q d4bc409 
>   ql/src/test/queries/clientpositive/input12_hadoop20.q 318cd37 
>   ql/src/test/queries/clientpositive/input39.q 04201dd 
>   ql/src/test/queries/clientpositive/join14.q 83346b4 
>   ql/src/test/queries/clientpositive/loadpart_err.q cc9c1fe 
>   ql/src/test/queries/clientpositive/sample_islocalmode_hook.q 0c8424b 
>   ql/src/test/queries/clientpositive/sample_islocalmode_hook_hadoop20.q 484e1fa 
>   ql/src/test/queries/clientpositive/split_sample.q 952eaf7 
>   ql/src/test/queries/clientpositive/stats_partscan_1.q cdf92e4 
>   ql/src/test/queries/clientpositive/uber_reduce.q bcef271 
>   ql/src/test/queries/clientpositive/udaf_percentile_approx_20.q 5b8ad7a 
>   ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table2_h23.q.out bdff1d7

>   ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table_h23.q.out de3cae6

>   ql/src/test/results/clientpositive/archive.q.out 5d15bd5 
>   ql/src/test/results/clientpositive/archive_corrupt.q.out 8aba24e 
>   ql/src/test/results/clientpositive/archive_excludeHadoop20.q.out 7ed53cb 
>   ql/src/test/results/clientpositive/auto_join14.q.out 450a961 
>   ql/src/test/results/clientpositive/combine2.q.out 921dd90 
>   ql/src/test/results/clientpositive/ctas.q.out c1e2dcc 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out 76f2a92 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 4695e8a 
>   ql/src/test/results/clientpositive/input12.q.out 20985eb 
>   ql/src/test/results/clientpositive/input39.q.out 1e05310 
>   ql/src/test/results/clientpositive/join14.q.out 1ea3746 
>   ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 39de7fe 
>   ql/src/test/results/clientpositive/split_sample.q.out 3a81f87 
>   ql/src/test/results/clientpositive/tez/ctas.q.out b90716e 
>   ql/src/test/results/clientpositive/uber_reduce.q.out 3888380 
>   service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 89084f9 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8cabf7e 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java bad533b

>   service/src/java/org/apache/hive/service/cli/session/HiveSessionProxy.java 0e6ea63

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 17e1d85 
>   shims/0.20/pom.xml 0f6eb17 
>   shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java a524573 
>   shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Jetty20Shims.java 13c6b31 
>   shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 1592c32

>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java dac05e6 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge23.java
a4cd37d 
>   shims/aggregator/pom.xml 4dd3dd7 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
19ba6a8 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenIdentifier.java
4ca3c0b 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java
19d1fbf 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSelector.java
f6e2420 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java
867b4ed 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
624ac6b 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java
cf60b7c 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/TokenStoreDelegationTokenSecretManager.java
8146d51 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/ZooKeeperTokenStore.java
91e4a69 
>   shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/client/TUGIAssumingTransport.java
fe18706 
>   shims/common-secure/src/main/java/org/apache/hadoop/security/token/delegation/HiveDelegationTokenSupport.java
6b39a14 
>   shims/common/pom.xml 7d0186f 
>   shims/common/src/main/java/org/apache/hadoop/fs/DefaultFileAccess.java dbd9f38 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java d1cbd2e 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java b84f1f2 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/Utils.java PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenIdentifier.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenSecretManager.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/DelegationTokenStore.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
d011c67 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/MemoryTokenStore.java PRE-CREATION

>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/TokenStoreDelegationTokenSecretManager.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/thrift/client/TUGIAssumingTransport.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationTokenSelector.java
PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/security/token/delegation/HiveDelegationTokenSupport.java
PRE-CREATION 
>   shims/pom.xml d43086f 
> 
> Diff: https://reviews.apache.org/r/27895/diff/
> 
> 
> Testing
> -------
> 
> Existing tests. Refactoring patch.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message