hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <ctang...@gmail.com>
Subject Review Request 28286: HIVE-8863:Cannot drop table with uppercase name after "compute statistics for columns"
Date Thu, 20 Nov 2014 18:28:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28286/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-8863
    https://issues.apache.org/jira/browse/HIVE-8863


Repository: hive-git


Description
-------

Hive is not able to drop a table or partition with uppercase db/table name after "compute
statistics for columns". It is because the identifier such as db/table name stored in stats
table TBL_COL_STATS and PART_COL_STATS are in lower case. But Hive preserves the db/table
name's case in its JDO query to delete the stats entries, which cause them not to be deleted,
thus the referential integrity violation arises when the table/partition is deleted.


Diffs
-----

  common/src/java/org/apache/hive/common/util/HiveStringUtils.java 2705f1e2e7247bcf94b94b17453c18f7826eb209

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1b14fb113e612c210297f516b18af6553a7016f4

  ql/src/test/queries/clientpositive/drop_partition_with_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/drop_table_with_stats.q PRE-CREATION 
  ql/src/test/results/clientpositive/drop_partition_with_stats.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/drop_table_with_stats.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/28286/diff/


Testing
-------

new qtests drop_table_with_stats and drop_partition_with_stats passed. submitted the patch
for pre-commit tests.


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message