hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohit Sabharwal" <mo...@cloudera.com>
Subject Re: Review Request 28147: HIVE-7073:Implement Binary in ParquetSerDe
Date Tue, 18 Nov 2014 17:45:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28147/#review61946
-----------------------------------------------------------


LGTM. Mickaƫl Lacour's suggestion of adding a null value test is a great one.

- Mohit Sabharwal


On Nov. 18, 2014, 1:58 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28147/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2014, 1:58 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> This patch includes:
> 1. binary support for ParquetHiveSerde
> 2. related test cases both in unit and ql test
> 
> 
> Diffs
> -----
> 
>   data/files/parquet_types.txt d342062 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java 472de8f

>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java
d5aae3b 
>   ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java c57dd99

>   ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 8ac7864 
>   ql/src/test/queries/clientpositive/parquet_types.q 22585c3 
>   ql/src/test/results/clientpositive/parquet_types.q.out 275897c 
> 
> Diff: https://reviews.apache.org/r/28147/diff/
> 
> 
> Testing
> -------
> 
> related UT and QL tests passed
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message