hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 28109: HiveServer2 dynamic service discovery: use persistent ephemeral nodes curator recipe
Date Sun, 16 Nov 2014 22:57:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review61691
-----------------------------------------------------------



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103469>

    I think it would be safer to close the PersistentEphemeralNode on any Exception.



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103470>

    should we deregister if this been deleted, irrespective of znode close failure ?



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103471>

    use logger here ?



service/src/java/org/apache/hive/service/server/HiveServer2.java
<https://reviews.apache.org/r/28109/#comment103472>

    instead of retrying for ever, lets quit after some reasonable number of attempts.
    maybe upto 5 minutes, checking every few seconds (2 sec ?)
    
    If it fails to delete even after long time (say 5 min), log an error and continue with
rest.


- Thejas Nair


On Nov. 16, 2014, 9:10 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2014, 9:10 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-8890
>     https://issues.apache.org/jira/browse/HIVE-8890
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8890
> 
> 
> Diffs
> -----
> 
>   pom.xml 2156fec 
>   service/pom.xml b9d3a40 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 17e1d85 
> 
> Diff: https://reviews.apache.org/r/28109/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message