hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 28064: HIVE-8844 Choose a persisent policy for RDD caching [Spark Branch]
Date Sat, 15 Nov 2014 02:08:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28064/#review61605
-----------------------------------------------------------


Looks good, some nits:


ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java
<https://reviews.apache.org/r/28064/#comment103341>

    Do you know why we have to do this, and cannot just use NONE?



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java
<https://reviews.apache.org/r/28064/#comment103338>

    Instead of hardcoding, can we just use the StorageHandler.MEMORY_AND_DISK if the string
is null?



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java
<https://reviews.apache.org/r/28064/#comment103339>

    Exception handling?


- Szehon Ho


On Nov. 15, 2014, 12:32 a.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28064/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 12:32 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8844
>     https://issues.apache.org/jira/browse/HIVE-8844
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changed spark cache policy to be configurable with default memory+disk.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java 79baea7 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java 8565ba0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 11f4236 
> 
> Diff: https://reviews.apache.org/r/28064/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message