hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang" <jxi...@cloudera.com>
Subject Re: Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]
Date Fri, 14 Nov 2014 19:21:39 GMT


> On Nov. 14, 2014, 6:51 p.m., Xuefu Zhang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java, line 332
> > <https://reviews.apache.org/r/28046/diff/1/?file=763735#file763735line332>
> >
> >     Nit: Probably this can be made into the part of for clause for cleanness. Same
blow.

Sure. Will fix.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28046/#review61473
-----------------------------------------------------------


On Nov. 14, 2014, 6:39 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28046/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 6:39 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8840
>     https://issues.apache.org/jira/browse/HIVE-8840
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Created a special comparable name for SparkWork to sort in topological order.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java d1ada44 
>   ql/src/test/results/clientpositive/spark/auto_join18.q.out 2d347a3 
>   ql/src/test/results/clientpositive/spark/auto_join18_multi_distinct.q.out 1a6cc33 
>   ql/src/test/results/clientpositive/spark/auto_join27.q.out ac8cc21 
>   ql/src/test/results/clientpositive/spark/auto_join30.q.out 6d44aec 
>   ql/src/test/results/clientpositive/spark/auto_join31.q.out 57a7b8f 
>   ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out d961067 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_10.q.out 8625f07 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out 03ffb12 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 063590f 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out 20b5adc 
>   ql/src/test/results/clientpositive/spark/bucket_map_join_tez2.q.out e7ec4c8 
>   ql/src/test/results/clientpositive/spark/column_access_stats.q.out 8c281be 
>   ql/src/test/results/clientpositive/spark/groupby10.q.out 60b4d50 
>   ql/src/test/results/clientpositive/spark/groupby11.q.out 445bb52 
>   ql/src/test/results/clientpositive/spark/groupby7_map_skew.q.out b76a002 
>   ql/src/test/results/clientpositive/spark/groupby7_noskew_multi_single_reducer.q.out
085a2ac 
>   ql/src/test/results/clientpositive/spark/groupby8.q.out 33d7d11 
>   ql/src/test/results/clientpositive/spark/groupby8_map.q.out 8beb293 
>   ql/src/test/results/clientpositive/spark/groupby8_map_skew.q.out 8beb293 
>   ql/src/test/results/clientpositive/spark/groupby8_noskew.q.out 8beb293 
>   ql/src/test/results/clientpositive/spark/groupby9.q.out ea218bf 
>   ql/src/test/results/clientpositive/spark/groupby_complex_types_multi_single_reducer.q.out
f5a1c6e 
>   ql/src/test/results/clientpositive/spark/groupby_cube1.q.out 443af21 
>   ql/src/test/results/clientpositive/spark/groupby_multi_insert_common_distinct.q.out
182478b 
>   ql/src/test/results/clientpositive/spark/groupby_position.q.out 5e044da 
>   ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out fede4a9 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 2cbe0d1 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out c599f4c 
>   ql/src/test/results/clientpositive/spark/join18.q.out f16fc04 
>   ql/src/test/results/clientpositive/spark/join18_multi_distinct.q.out 2960522 
>   ql/src/test/results/clientpositive/spark/join19.q.out 5220349 
>   ql/src/test/results/clientpositive/spark/join29.q.out 374f89c 
>   ql/src/test/results/clientpositive/spark/join31.q.out 00c2cba 
>   ql/src/test/results/clientpositive/spark/join32.q.out 8c538fc 
>   ql/src/test/results/clientpositive/spark/join32_lessSize.q.out 00d3c63 
>   ql/src/test/results/clientpositive/spark/join33.q.out 8c538fc 
>   ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 0960ffc 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 061e5e8 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_2.q.out 3b92924 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out d50e99e 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_4.q.out 9c1d2e6 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 25dcfe5 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual2.q.out bf32c7e 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out 3dc3481 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual4.q.out e55c192 
>   ql/src/test/results/clientpositive/spark/join_reorder2.q.out ce57266 
>   ql/src/test/results/clientpositive/spark/join_reorder3.q.out 16ad478 
>   ql/src/test/results/clientpositive/spark/join_star.q.out 430b699 
>   ql/src/test/results/clientpositive/spark/join_vc.q.out e4d4724 
>   ql/src/test/results/clientpositive/spark/limit_pushdown.q.out 9ab8982 
>   ql/src/test/results/clientpositive/spark/mergejoins_mixed.q.out c667fdc 
>   ql/src/test/results/clientpositive/spark/multi_insert_mixed.q.out f48439e 
>   ql/src/test/results/clientpositive/spark/multi_insert_move_tasks_share_dependencies.q.out
022079f 
>   ql/src/test/results/clientpositive/spark/multi_join_union.q.out cfc354f 
>   ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 41c81ed 
>   ql/src/test/results/clientpositive/spark/ppd_join4.q.out 04e4758 
>   ql/src/test/results/clientpositive/spark/ppd_join_filter.q.out 6ee0c8f 
>   ql/src/test/results/clientpositive/spark/reduce_deduplicate_exclude_join.q.out 54fe587

>   ql/src/test/results/clientpositive/spark/skewjoinopt1.q.out d53b073 
>   ql/src/test/results/clientpositive/spark/skewjoinopt15.q.out b1a0ee8 
>   ql/src/test/results/clientpositive/spark/skewjoinopt2.q.out ac1d6c6 
>   ql/src/test/results/clientpositive/spark/skewjoinopt9.q.out 5e2da76 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_25.q.out 4fda89b 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 0856b37 
>   ql/src/test/results/clientpositive/spark/subquery_multiinsert.q.out c5f68c6 
>   ql/src/test/results/clientpositive/spark/temp_table.q.out e75fa0e 
>   ql/src/test/results/clientpositive/spark/tez_join_tests.q.out 14406df 
>   ql/src/test/results/clientpositive/spark/tez_joins_explain.q.out 3f080a6 
>   ql/src/test/results/clientpositive/spark/union19.q.out c32fd33 
>   ql/src/test/results/clientpositive/spark/union23.q.out e61b324 
>   ql/src/test/results/clientpositive/spark/union25.q.out 4a36b29 
>   ql/src/test/results/clientpositive/spark/union_ppr.q.out 7611f3b 
>   ql/src/test/results/clientpositive/spark/vector_left_outer_join.q.out d505232 
>   ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 0cdb7c8 
>   ql/src/test/results/clientpositive/spark/vectorized_nested_mapjoin.q.out 4d4dd94 
>   ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 5968af6 
> 
> Diff: https://reviews.apache.org/r/28046/diff/
> 
> 
> Testing
> -------
> 
> Updated the qfile test results, which looks much better now.
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message