hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <chao....@cloudera.com>
Subject Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]
Date Thu, 13 Nov 2014 00:49:23 GMT


> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line
326
> > <https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line326>
> >
> >     Can we use "SPARKHASHTABLESINK", or something similar?
> 
> Jimmy Xiang wrote:
>     Does this need match the Operator type?

I think these two are not related. Somebody can correct me if I'm wrong.
One potential issue with using the same name is that RuleRegExp may become harder to define.


- Chao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27933/#review61150
-----------------------------------------------------------


On Nov. 12, 2014, 11:58 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27933/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 11:58 p.m.)
> 
> 
> Review request for hive, Chao Sun, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8810
>     https://issues.apache.org/jira/browse/HIVE-8810
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fixed the Spark HashTableSinkOperator
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 78d9012 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java f1c3564 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java
a58a6c5 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/SparkHashTableSinkDesc.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/27933/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message