hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 27566: HIVE-8609: move beeline to jline2
Date Wed, 12 Nov 2014 02:25:00 GMT


> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 1
> > <https://reviews.apache.org/r/27566/diff/2/?file=757659#file757659line1>
> >
> >     I see, this class is being copied from JLine source. We'll need special handling
of this class.
> >     
> >     (1) We need to add the original license BSD-2 to the top of the file with the
apache license below it.
> >     
> >     (2) We need to add a section to the top level license file, in the style of:
https://github.com/apache/hive/blob/trunk/LICENSE#L212
> >     
> >     (3) We should consider reformatting the file to comply with hive standards
> >     
> >     Note that my specific example has been removed and as such we need to remove
it from the top level license file. I filed HIVE-8826 to do that. Should be an easy fix.

Thank Brock for your kind remind.
(1) The original license to the top of the file added
(2) JLine part is already added, does this file need a standalone section in this license
file?
(3) Formatted in HIVE code style.


> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > hcatalog/hcatalog-pig-adapter/pom.xml, line 57
> > <https://reviews.apache.org/r/27566/diff/2/?file=757669#file757669line57>
> >
> >     I am not 100% sure this will work, let's see.

Test locally already, anyway, still wait for the CI result :)


> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote:
> > beeline/src/java/org/apache/hive/beeline/SQLCompleter.java, line 53
> > <https://reviews.apache.org/r/27566/diff/2/?file=757664#file757664line53>
> >
> >     Wow, this is not good. I created HIVE-8825 to fix catching Throwable. Should
be quick fix.

Let's do it in HIVE-8825 Once this patch ready.


- cheng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27566/#review60788
-----------------------------------------------------------


On Nov. 11, 2014, 11:45 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27566/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 11:45 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8609: move beeline to jline2
> The following will be changed:
> * MultiCompletor-> AggregateCompleter
> * SimpleCompletor->StringsCompleter
> * Terminal.getTerminalWidth() -> Terminal.getWidth()
> * Terminal is an interface now; -> use TerminalFactory to get instances of a Terminal
> * String -> CharSequence
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/AbstractCommandHandler.java a9479d5 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 8539a41 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java PRE-CREATION

>   beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompletor.java 52313e6 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BeeLineCompletor.java c6bb4fe 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java f73fb44 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/BooleanCompletor.java 3e88c53 
>   beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/CommandHandler.java bab1778 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 7e366dc 
>   beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java ab67700 
>   beeline/src/java/org/apache/hive/beeline/ReflectiveCommandHandler.java 2b957f2 
>   beeline/src/java/org/apache/hive/beeline/SQLCompleter.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SQLCompletor.java 844b9ae 
>   beeline/src/java/org/apache/hive/beeline/TableNameCompletor.java bc0d9be 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 0ccaacb 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java 88a37d5 
>   hcatalog/hcatalog-pig-adapter/pom.xml 2d959e6 
>   pom.xml ec8c4fe 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java dea3460 
> 
> Diff: https://reviews.apache.org/r/27566/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message