hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 27745: HIVE-8621 Dump small table join data for map-join [Spark Branch]
Date Fri, 07 Nov 2014 21:51:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27745/#review60386
-----------------------------------------------------------


If it's found that too much customization is needed for Spark, we might as well extend it
from instead.


ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
<https://reviews.apache.org/r/27745/#comment101750>

    Don't we need this any more?



ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
<https://reviews.apache.org/r/27745/#comment101752>

    This doesn't seem resolve conflicts for files generated by different partitions. These
partitions can run on different nodes, so fileIndex might be the same.


- Xuefu Zhang


On Nov. 7, 2014, 9:34 p.m., Jimmy Xiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27745/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 9:34 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8621
>     https://issues.apache.org/jira/browse/HIVE-8621
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> In case spark, HashTableSinkOperator should dump files to a folder expected by HashTableLoader.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java f0e04e7 
> 
> Diff: https://reviews.apache.org/r/27745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jimmy Xiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message