Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 30 Oct 2014 23:16:34 +0000 (UTC)
From: "Jason Dere (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12750198.1414096358000.377777.1414710994355@Atlassian.JIRA>
In-Reply-To: <JIRA.12750198.1414096358000@Atlassian.JIRA>
References: <JIRA.12750198.1414096358000@Atlassian.JIRA>
 <JIRA.12750198.1414096358819@arcas>
Subject: [jira] [Updated] (HIVE-8579) Guaranteed NPE in DDLSemanticAnalyzer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HIVE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dere updated HIVE-8579:
-----------------------------
    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed to trunk/branch-0.14

> Guaranteed NPE in DDLSemanticAnalyzer
> -------------------------------------
>
>                 Key: HIVE-8579
>                 URL: https://issues.apache.org/jira/browse/HIVE-8579
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Lars Francke
>            Assignee: Jason Dere
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8579.1.patch, HIVE-8579.1.patch
>
>
> This was added by [~jdere] in HIVE-8411. I don't fully understand the code (i.e. what it means when desc is null) but I'm sure, Jason, you can fix it without much trouble?
> {code}
> if (desc == null || !AlterTableDesc.doesAlterTableTypeSupportPartialPartitionSpec(desc.getOp())) {
>   throw new SemanticException( ErrorMsg.ALTER_TABLE_TYPE_PARTIAL_PARTITION_SPEC_NO_SUPPORTED, desc.getOp().name());
>         } else if (!conf.getBoolVar(HiveConf.ConfVars.DYNAMICPARTITIONING)) {
>           throw new SemanticException(ErrorMsg.DYNAMIC_PARTITION_DISABLED);
>         }
> {code}
> You check for whether {{desc}} is null but then use it to do {{desc.getOp()}}.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)