Return-Path: 
 <dev-return-109911-apmail-hive-dev-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-dev-archive@www.apache.org
Delivered-To: apmail-hive-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4071317A22
	for <apmail-hive-dev-archive@www.apache.org>;
 Thu, 23 Oct 2014 22:13:35 +0000 (UTC)
Received: (qmail 2314 invoked by uid 500); 23 Oct 2014 22:13:34 -0000
Delivered-To: apmail-hive-dev-archive@hive.apache.org
Received: (qmail 2248 invoked by uid 500); 23 Oct 2014 22:13:34 -0000
Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hive.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hive.apache.org>
List-Post: <mailto:dev@hive.apache.org>
List-Id: <dev.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list dev@hive.apache.org
Received: (qmail 2235 invoked by uid 500); 23 Oct 2014 22:13:34 -0000
Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org
Received: (qmail 2230 invoked by uid 99); 23 Oct 2014 22:13:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Oct 2014 22:13:34 +0000
Date: Thu, 23 Oct 2014 22:13:34 +0000 (UTC)
From: "Lars Francke (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12750145.1414087969000.326762.1414102414553@Atlassian.JIRA>
In-Reply-To: <JIRA.12750145.1414087969000@Atlassian.JIRA>
References: <JIRA.12750145.1414087969000@Atlassian.JIRA>
 <JIRA.12750145.1414087969852@arcas>
Subject: [jira] [Commented] (HIVE-8576) Guaranteed NPE in
 StatsRulesProcFactory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HIVE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182068#comment-14182068 ] 

Lars Francke commented on HIVE-8576:
------------------------------------

I don't think the test failures are related to the patch.

> Guaranteed NPE in StatsRulesProcFactory
> ---------------------------------------
>
>                 Key: HIVE-8576
>                 URL: https://issues.apache.org/jira/browse/HIVE-8576
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>         Attachments: HIVE-8576.1.patch
>
>
> Code looks like this:
> {code}
>     private List<Integer> getPrimaryKeyCandidates(List<Operator<? extends OperatorDesc>> ops) {
>       List<Integer> result = Lists.newArrayList();
>       if (ops != null || !ops.isEmpty()) {
>         for (int i = 0; i < ops.size(); i++) {
> {code}
> The {{||}} should be {{&&}} as the current {{if}} statement can be rewritten as {{!(ops == null && ops.isEmpty())}} which doesn't make sense.
> Or am I missing something?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)