Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9254177E0 for ; Wed, 22 Oct 2014 02:44:51 +0000 (UTC) Received: (qmail 3930 invoked by uid 500); 22 Oct 2014 02:44:51 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3854 invoked by uid 500); 22 Oct 2014 02:44:51 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3837 invoked by uid 99); 22 Oct 2014 02:44:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2014 02:44:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 93FD11DF539; Wed, 22 Oct 2014 02:44:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8691023815596816622==" MIME-Version: 1.0 Subject: Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select From: "John Pullokkaran" To: "John Pullokkaran" , "Ashutosh Chauhan" Cc: "Sergey Shelukhin" , "hive" Date: Wed, 22 Oct 2014 02:44:55 -0000 Message-ID: <20141022024455.1282.74187@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Pullokkaran" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25550/ X-Sender: "John Pullokkaran" References: <20141021011332.1283.81168@reviews.apache.org> In-Reply-To: <20141021011332.1283.81168@reviews.apache.org> Reply-To: "John Pullokkaran" X-ReviewRequest-Repository: hive-git --===============8691023815596816622== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25550/#review57733 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Some tests reuses semanticanalyzer possibly from different threads. Its more defensive code than encountered problem. - John Pullokkaran On Oct. 21, 2014, 1:13 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25550/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 1:13 a.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java dee7d7e > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 37cbf7f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d > ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 > ql/src/test/queries/clientpositive/ctas_colname.q 5322626 > ql/src/test/queries/clientpositive/decimal_serde.q cf3a86c > ql/src/test/queries/clientpositive/insert0.q PRE-CREATION > ql/src/test/results/clientpositive/ctas_colname.q.out 97dacf6 > ql/src/test/results/clientpositive/decimal_serde.q.out e461c2e > ql/src/test/results/clientpositive/insert0.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/25550/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > > --===============8691023815596816622==--