Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BEB421788E for ; Fri, 17 Oct 2014 18:59:57 +0000 (UTC) Received: (qmail 97768 invoked by uid 500); 17 Oct 2014 18:59:57 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 97705 invoked by uid 500); 17 Oct 2014 18:59:57 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 97689 invoked by uid 99); 17 Oct 2014 18:59:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 18:59:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7BC7C1DF370; Fri, 17 Oct 2014 18:59:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0919170875251439367==" MIME-Version: 1.0 Subject: Review Request 26887: StatsNoJobTask doesn't close RecordReader, FSDataInputStream of which keeps open to prevent stale data clean From: "XIAOBING ZHOU" To: "XIAOBING ZHOU" , "hive" Date: Fri, 17 Oct 2014 18:59:52 -0000 Message-ID: <20141017185952.30984.31213@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "XIAOBING ZHOU" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26887/ X-Sender: "XIAOBING ZHOU" Reply-To: "XIAOBING ZHOU" X-ReviewRequest-Repository: hive-git --===============0919170875251439367== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26887/ ----------------------------------------------------------- Review request for hive. Repository: hive-git Description ------- run the test mvn -Phadoop-2 test -Dtest=TestCliDriver -Dqfile=alter_merge_stats_orc.q to reproduce it. Simply, this query does three data loads which generates three base orc files. ANALYZE TABLE...COMPUTE STATISTICS NOSCAN will execute StatsNoJobTask to get stats, where file handle is held so as not able to clean base file. As a result, after running ALTER TABLE..CONCATENATE, follow-up queries go to stale base file and merged file. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/exec/StatsNoJobTask.java 07efb8f Diff: https://reviews.apache.org/r/26887/diff/ Testing ------- passed alter_merge_stats_orc.q Thanks, XIAOBING ZHOU --===============0919170875251439367==--