Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D678E17F74 for ; Wed, 15 Oct 2014 00:45:11 +0000 (UTC) Received: (qmail 25170 invoked by uid 500); 15 Oct 2014 00:45:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 25103 invoked by uid 500); 15 Oct 2014 00:45:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 25090 invoked by uid 99); 15 Oct 2014 00:45:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Oct 2014 00:45:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0FAB81DDF7E; Wed, 15 Oct 2014 00:45:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8810256371075889772==" MIME-Version: 1.0 Subject: Re: Review Request 25238: make timestamp accessible in the hbase KeyValue From: "Navis Ryu" To: "Navis Ryu" , "Swarnim Kulkarni" , "hive" Date: Wed, 15 Oct 2014 00:45:06 -0000 Message-ID: <20141015004506.24413.43154@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/25238/ X-Sender: "Navis Ryu" References: <20140902061514.16960.48341@reviews.apache.org> In-Reply-To: <20140902061514.16960.48341@reviews.apache.org> Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============8810256371075889772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25238/ ----------------------------------------------------------- (Updated Oct. 15, 2014, 12:45 a.m.) Review request for hive. Changes ------- Removed String mapping Bugs: HIVE-2828 https://issues.apache.org/jira/browse/HIVE-2828 Repository: hive-git Description ------- Originated from HIVE-2781 and not accepted, but I think this could be helpful to someone. By using special column notation ':timestamp' in HBASE_COLUMNS_MAPPING, user might access timestamp value in hbase KeyValue. {code} CREATE TABLE hbase_table (key int, value string, time timestamp) STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' WITH SERDEPROPERTIES ("hbase.columns.mapping" = ":key,cf:string,:timestamp") {code} Diffs (updated) ----- hbase-handler/src/java/org/apache/hadoop/hive/hbase/ColumnMappings.java fbd1308 hbase-handler/src/java/org/apache/hadoop/hive/hbase/DefaultHBaseKeyFactory.java 12c5377 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java c6c42b4 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java aedd843 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDeParameters.java 9efa494 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java feb3cd1 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseInputFormatUtil.java 5aa1d796 hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 4ac0803 hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java 6ac8423 hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestLazyHBaseObject.java 9a31f0f hbase-handler/src/test/queries/positive/hbase_timestamp.q PRE-CREATION hbase-handler/src/test/results/positive/hbase_timestamp.q.out PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 960fc1d serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java 0ab27ff Diff: https://reviews.apache.org/r/25238/diff/ Testing ------- Thanks, Navis Ryu --===============8810256371075889772==--