Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0780417471 for ; Mon, 13 Oct 2014 19:33:20 +0000 (UTC) Received: (qmail 65267 invoked by uid 500); 13 Oct 2014 19:33:19 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 65194 invoked by uid 500); 13 Oct 2014 19:33:19 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 65180 invoked by uid 99); 13 Oct 2014 19:33:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Oct 2014 19:33:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DE1701DDEE1; Mon, 13 Oct 2014 19:33:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3979057779775030101==" MIME-Version: 1.0 Subject: Re: Review Request 26427: Disable CBO when indexes are used From: "pengcheng xiong" To: "Gunther Hagleitner" Cc: "pengcheng xiong" , "hive" Date: Mon, 13 Oct 2014 19:33:14 -0000 Message-ID: <20141013193314.24426.62724@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "pengcheng xiong" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26427/ X-Sender: "pengcheng xiong" References: <20141013193200.24414.35793@reviews.apache.org> In-Reply-To: <20141013193200.24414.35793@reviews.apache.org> Reply-To: "pengcheng xiong" X-ReviewRequest-Repository: hive-git --===============3979057779775030101== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26427/ ----------------------------------------------------------- (Updated Oct. 13, 2014, 7:33 p.m.) Review request for hive and Gunther Hagleitner. Changes ------- In this patch, (1) index is enabled for the following test cases in CliDriver: alter_concatenate_indexed_table.q,alter_index.q,authorization_index.q,drop_index_removes_partition_dirs.q,index_auth.q,index_auto.q,index_auto_empty.q,index_auto_file_format.q,index_auto_mult_tables.q,index_auto_mult_tables_compact.q,index_auto_multiple.q,index_auto_multipleX.q,index_auto_partitioned.q,index_auto_self_join.q,index_auto_unused.q,index_auto_update.q,index_bitmap.q,index_bitmap1.q,index_bitmap2.q,index_bitmap3.q,index_bitmap_auto.q,index_bitmap_auto_partitioned.q,index_bitmap_compression.q,index_bitmap_rc.q,index_compact.q,index_compact_1.q,index_compact_2.q,index_compact_3.q,index_compact_binary_search.q,index_compression.q,index_creation.q,index_serde.q,index_stale.q,index_stale_partitioned.q,show_indexes_edge_cases.q,show_indexes_syntax.q,udf_index.q (2) the "fetch.task.conversion" optimization is disabled for index_auto_partitioned.q and index_bitmap_auto_partitioned.q because it will block index optimizer. (3) And, index is enabled for ql_rewrite_gbtoidx.q in TestMinimrCliDriver Repository: hive-git Description ------- Disable CBO when indexes are used Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 51fc68f ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 683618f ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java bc4ad2f ql/src/test/queries/clientpositive/index_auto_partitioned.q 49df8f2 ql/src/test/queries/clientpositive/index_bitmap_auto_partitioned.q 011d77a Diff: https://reviews.apache.org/r/26427/diff/ Testing ------- Thanks, pengcheng xiong --===============3979057779775030101==--