Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C532D17B7C for ; Sat, 11 Oct 2014 00:31:08 +0000 (UTC) Received: (qmail 9137 invoked by uid 500); 11 Oct 2014 00:31:08 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 9040 invoked by uid 500); 11 Oct 2014 00:31:08 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 9025 invoked by uid 99); 11 Oct 2014 00:31:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Oct 2014 00:31:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D3B951DDD94; Sat, 11 Oct 2014 00:31:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1335130580381990597==" MIME-Version: 1.0 Subject: Re: Review Request 26569: HIVE-8276 - Separate shuffle from ReduceTran and so create ShuffleTran [Spark Branch] From: "Chao Sun" To: "Xuefu Zhang" Cc: "hive" , "Chao Sun" Date: Sat, 11 Oct 2014 00:31:03 -0000 Message-ID: <20141011003103.15371.68497@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26569/ X-Sender: "Chao Sun" References: <20141010191836.24818.96580@reviews.apache.org> In-Reply-To: <20141010191836.24818.96580@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============1335130580381990597== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26569/ ----------------------------------------------------------- (Updated Oct. 11, 2014, 12:31 a.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-8276 https://issues.apache.org/jira/browse/HIVE-8276 Repository: hive-git Description ------- Currently ShuffleTran captures both shuffle and reduce side processing. Per HIVE-8118, sometimes the output RDD from shuffle needs to be cached for better performance. Thus, it makes sense to separate shuffle from Reduce and create ShuffleTran class. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/IdentityTran.java 6c3cf2f ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java 0732e06 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapTran.java e62527c ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ReduceTran.java 52ac724 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleTran.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkPlanGenerator.java 8e251df ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java e770158 Diff: https://reviews.apache.org/r/26569/diff/ Testing ------- Thanks, Chao Sun --===============1335130580381990597==--