Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE55017F2F for ; Fri, 10 Oct 2014 04:42:06 +0000 (UTC) Received: (qmail 41528 invoked by uid 500); 10 Oct 2014 04:42:06 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 41452 invoked by uid 500); 10 Oct 2014 04:42:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 41437 invoked by uid 99); 10 Oct 2014 04:42:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Oct 2014 04:42:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3723C1DDDBF; Fri, 10 Oct 2014 04:42:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5908343546724678884==" MIME-Version: 1.0 Subject: Re: Review Request 26117: HIVE-8094 add LIKE keyword support for SHOW FUNCTIONS From: "peter liu" To: "Thejas Nair" Cc: "peter liu" , "hive" Date: Fri, 10 Oct 2014 04:42:02 -0000 Message-ID: <20141010044202.15371.45266@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "peter liu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26117/ X-Sender: "peter liu" References: <20140927210156.14999.77630@reviews.apache.org> In-Reply-To: <20140927210156.14999.77630@reviews.apache.org> Reply-To: "peter liu" X-ReviewRequest-Repository: hive-git --===============5908343546724678884== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26117/ ----------------------------------------------------------- (Updated Oct. 10, 2014, 4:42 a.m.) Review request for hive and Thejas Nair. Bugs: HIVE-8094 https://issues.apache.org/jira/browse/HIVE-8094 Repository: hive-git Description ------- It would be nice to add LIKE keyword support for SHOW FUNCTIONS as below, and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES. bq. SHOW FUNCTIONS LIKE 'foo*'; Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d5374bc ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d047b25 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 4e58ad8 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ef6d6f7 ql/src/java/org/apache/hadoop/hive/ql/plan/ShowFunctionsDesc.java 5ea99f8 ql/src/test/queries/clientpositive/show_functions.q c09f50a ql/src/test/results/clientpositive/show_functions.q.out 775cc74 Diff: https://reviews.apache.org/r/26117/diff/ Testing ------- Thanks, peter liu --===============5908343546724678884==--