Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 14AD917256 for ; Wed, 8 Oct 2014 04:06:12 +0000 (UTC) Received: (qmail 29432 invoked by uid 500); 8 Oct 2014 04:06:11 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 29348 invoked by uid 500); 8 Oct 2014 04:06:11 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 29336 invoked by uid 99); 8 Oct 2014 04:06:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 04:06:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3187F1DDD31; Wed, 8 Oct 2014 04:06:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7078024383134201846==" MIME-Version: 1.0 Subject: Review Request 26435: Self join may fail if one side has VCs and other doesn't From: "Navis Ryu" To: "Navis Ryu" , "hive" Date: Wed, 08 Oct 2014 04:06:07 -0000 Message-ID: <20141008040607.15371.34603@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26435/ X-Sender: "Navis Ryu" Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============7078024383134201846== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26435/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-8186 https://issues.apache.org/jira/browse/HIVE-8186 Repository: hive-git Description ------- {noformat}select t1.BLOCK__OFFSET__INSIDE__FILE,t2.BLOCK__OFFSET__INSIDE__FILE from src t1 join src t2 on t1.key = t2.key;{noformat} Passes {noformat}select t2.BLOCK__OFFSET__INSIDE__FILE from src t1 join src t2 on t1.key = t2.key;{noformat} Fails. The issue is that LazyBinarySerDe OI receives data intended for UnionStructObjectInspector. Judging by the above it has something to do with scanning table once for two aliases. I'll look tomorrow Diffs ----- data/conf/hive-log4j.properties 7f5dfc4 ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java f624bf4 ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 3dc7c76 ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java d8698da ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 155002a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java 311f6d6 ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java 78d4d1f ql/src/test/org/apache/hadoop/hive/ql/exec/TestOperators.java 90e4cad ql/src/test/queries/clientpositive/join_vc.q 63b3da7 ql/src/test/results/clientpositive/join_vc.q.out 12004ca Diff: https://reviews.apache.org/r/26435/diff/ Testing ------- Thanks, Navis Ryu --===============7078024383134201846==--