Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 03A40172E1 for ; Tue, 7 Oct 2014 21:40:13 +0000 (UTC) Received: (qmail 38331 invoked by uid 500); 7 Oct 2014 21:40:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 38259 invoked by uid 500); 7 Oct 2014 21:40:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 38242 invoked by uid 99); 7 Oct 2014 21:40:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 21:40:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 67A4F1DDD13; Tue, 7 Oct 2014 21:40:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3454774729172259298==" MIME-Version: 1.0 Subject: Re: Review Request 26209: CBO trunk merge: union11 test fails due to incorrect plan From: "Sergey Shelukhin" To: "Ashutosh Chauhan" Cc: "pengcheng xiong" , "hive" , "Sergey Shelukhin" Date: Tue, 07 Oct 2014 21:40:08 -0000 Message-ID: <20141007214008.15371.12602@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sergey Shelukhin" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26209/ X-Sender: "Sergey Shelukhin" References: <20141006173948.20120.20829@reviews.apache.org> In-Reply-To: <20141006173948.20120.20829@reviews.apache.org> Reply-To: "Sergey Shelukhin" X-ReviewRequest-Repository: hive-git --===============3454774729172259298== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26209/#review55715 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java whitespace; also elsewhere ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java nit - can just be one line ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java I think parent is always a projection, so it's SingleRel and there's only one input. Type can be made more specific all the way from introduceDerivedTable to here - Sergey Shelukhin On Oct. 6, 2014, 5:39 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26209/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 5:39 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > create a derived table with new proj and aggr to address it > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/PlanModifierForASTConv.java 3d90ae7 > ql/src/test/queries/clientpositive/cbo_correctness.q f7f0722 > ql/src/test/results/clientpositive/cbo_correctness.q.out 3335d4d > ql/src/test/results/clientpositive/tez/cbo_correctness.q.out 5920612 > > Diff: https://reviews.apache.org/r/26209/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > > --===============3454774729172259298==--