Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E81317BC4 for ; Fri, 3 Oct 2014 19:06:24 +0000 (UTC) Received: (qmail 4661 invoked by uid 500); 3 Oct 2014 19:06:22 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 4585 invoked by uid 500); 3 Oct 2014 19:06:22 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 4572 invoked by uid 99); 3 Oct 2014 19:06:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 19:06:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 923131DDC7C; Fri, 3 Oct 2014 19:06:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5239759913572068282==" MIME-Version: 1.0 Subject: Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start. From: "Vaibhav Gumashta" To: "Vaibhav Gumashta" , "XIAOBING ZHOU" , "hive" Date: Fri, 03 Oct 2014 19:06:18 -0000 Message-ID: <20141003190618.19177.81653@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vaibhav Gumashta" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/26321/ X-Sender: "Vaibhav Gumashta" References: <20141003182703.19177.23418@reviews.apache.org> In-Reply-To: <20141003182703.19177.23418@reviews.apache.org> Reply-To: "Vaibhav Gumashta" X-ReviewRequest-Repository: hive-git --===============5239759913572068282== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55378 ----------------------------------------------------------- bin/ext/hiveserver2.cmd I don't think the "-hiveconf" paramaters should be part of the cmd. I see that you are trying to override the default value of some of these, but I think it is more appropriate to do that at the admin level (i.e. whichever admin service is managing the startup of hive). common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Can you add a description for this new param (for why this is required) ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java Can you add a comment here explaining the intent of using HIVE_HADOOP_CLASSPATH? - Vaibhav Gumashta On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26321/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 6:27 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. > > > Diffs > ----- > > bin/ext/hiveserver2.cmd a5f3bb5 > bin/hive.cmd c2e9853 > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 > > Diff: https://reviews.apache.org/r/26321/diff/ > > > Testing > ------- > > > Thanks, > > XIAOBING ZHOU > > --===============5239759913572068282==--