hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8605) HIVE-5799 breaks backward compatibility for time values in config
Date Wed, 29 Oct 2014 20:06:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188908#comment-14188908
] 

Alan Gates commented on HIVE-8605:
----------------------------------

I would say it's just a bug fix.  Going forward we don't want people using 'l' as a modifier
for time units, so it's probably better not to document it.

> HIVE-5799 breaks backward compatibility for time values in config
> -----------------------------------------------------------------
>
>                 Key: HIVE-8605
>                 URL: https://issues.apache.org/jira/browse/HIVE-8605
>             Project: Hive
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 0.14.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Blocker
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8605.2.patch, HIVE-8605.patch
>
>
> It is legal for long values in the config file to have an L or for float values to have
an f.  For example, the default value for hive.compactor.check.interval was 300L.  As part
of HIVE-5799, many long values were converted to TimeUnit.  Attempts to read these values
now throw "java.lang.IllegalArgumentException: Invalid time unit l"
> We need to change this to ignore the L or f, so that users existing config files don't
break.  I propose to do this by changing HiveConf.unitFor to detect the L or f and interpret
it to mean the default time unit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message