hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8583) HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
Date Fri, 24 Oct 2014 06:05:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182481#comment-14182481
] 

Lars Francke commented on HIVE-8583:
------------------------------------

As far as I understand the work is done on the non-replaced original configuration properties:

{code}
  void addJobConfToEnvironment(Configuration conf, Map<String, String> env) {
    Iterator<Map.Entry<String, String>> it = conf.iterator();
    while (it.hasNext()) {
      Map.Entry<String, String> en = it.next();
      String name = en.getKey();
      if (!blackListed(name)) {
        String value = conf.get(name); // does variable expansion
        name = safeEnvVarName(name);
{code}

So the replacing happens later.

BTW. the replaceAll is wrong too. It takes a regex so "." means every character. So it'd replace
everything with underscores.

> HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist
> ---------------------------------------------------------------
>
>                 Key: HIVE-8583
>                 URL: https://issues.apache.org/jira/browse/HIVE-8583
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-8583.1.patch
>
>
> [~alangates] added the following in HIVE-8341:
> {code}
>         String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString());
>         if (bl != null && bl.length() > 0) {
>           String[] bls = bl.split(",");
>           for (String b : bls) {
>             b.replaceAll(".", "_");
>             blackListedConfEntries.add(b);
>           }
>         }
> {code}
> The {{replaceAll}} call is confusing as its result is not used at all.
> This patch contains the following:
> * Minor style modification (missorted modifiers)
> * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST
> * Removes replaceAll
> * Lets blackListed take a Configuration job as parameter which allowed me to add a test
for this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message