hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-8481) Some of jdbc2 calls ignores non-success from hiveserver2
Date Tue, 21 Oct 2014 19:53:35 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178935#comment-14178935
] 

Thejas M Nair edited comment on HIVE-8481 at 10/21/14 7:53 PM:
---------------------------------------------------------------

I don't see SUCCESS_WITH_INFO_STATUS used anywhere in server side. So the use of verifySuccessWithInfo
does not make sense. Looks like we should clean it up and replace the calls to it with verifySuccess
.
But I don't understand how/if the change in HIVE-8186 is causing the test failure.




was (Author: thejas):
I don't see SUCCESS_WITH_INFO_STATUS used anywhere in server side. So the use of verifySuccessWithInfo
does not make sense. Looks like we should clean it up and replace the calls to it with verifySuccess
.
But I don't understand why the change in HIVE-8186 is causing the test failure.



> Some of jdbc2 calls ignores non-success from hiveserver2
> --------------------------------------------------------
>
>                 Key: HIVE-8481
>                 URL: https://issues.apache.org/jira/browse/HIVE-8481
>             Project: Hive
>          Issue Type: Bug
>          Components: JDBC
>            Reporter: Navis
>            Priority: Blocker
>
> Fixing test fails in HIVE-8186, I've found some failures are ignored by jdbc client.
Below is code part that verifies result of jdbc call.
> {noformat}
> public static void verifySuccess(TStatus status, boolean withInfo) throws SQLException
{
>     if ((status.getStatusCode() != TStatusCode.SUCCESS_STATUS) &&
>         (withInfo && (status.getStatusCode() != TStatusCode.SUCCESS_WITH_INFO_STATUS)))
{
>         throw new HiveSQLException(status);
>     }
>   }
> {noformat}
> If withInfo is false(verifySuccess), it ignores status. By fixing this, two tests are
failed. (http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1285/testReport/)
> {noformat}
> org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeProxyAuth
> org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeTokenAuth
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message