hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8284) Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys()
Date Wed, 15 Oct 2014 09:46:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172210#comment-14172210
] 

Hive QA commented on HIVE-8284:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12674726/HIVE-8284.patch

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 6559 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_parallel
org.apache.hive.beeline.TestSchemaTool.testSchemaInit
org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1273/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1273/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1273/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12674726

> Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-8284
>                 URL: https://issues.apache.org/jira/browse/HIVE-8284
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Ted Yu
>            Assignee: JongWon Park
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8284.patch
>
>
> {code}
>     double numRows = tScan.getRows();
> ...
>         double r = cStat.getRange().maxValue.doubleValue() -
>             cStat.getRange().minValue.doubleValue() + 1;
>         isKey = (numRows == r);
> {code}
> The equality check should use a small epsilon as tolerance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message