hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laljo John Pullokkaran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-8222) CBO Trunk Merge: Fix Check Style issues
Date Sat, 11 Oct 2014 00:53:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167888#comment-14167888
] 

Laljo John Pullokkaran commented on HIVE-8222:
----------------------------------------------

Lars,
   thanks for rebasing the patch. I have two generic comments:

 1. This patch involves non CBO files
 2. Removal of type casts in may places in the code.

Since this is specific to CBO, please restrict style changes to CBO.
Removal of type cast, at the least may require assertions for expected type.

> CBO Trunk Merge: Fix Check Style issues
> ---------------------------------------
>
>                 Key: HIVE-8222
>                 URL: https://issues.apache.org/jira/browse/HIVE-8222
>             Project: Hive
>          Issue Type: Sub-task
>          Components: CBO
>            Reporter: Laljo John Pullokkaran
>            Assignee: Lars Francke
>         Attachments: HIVE-8222.1.patch, HIVE-8222.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message