hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-6934) PartitionPruner doesn't handle top level constant expression correctly
Date Tue, 21 Oct 2014 03:39:33 GMT

    [ https://issues.apache.org/jira/browse/HIVE-6934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177889#comment-14177889
] 

Hive QA commented on HIVE-6934:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12675979/HIVE-6934.92.patch

{color:green}SUCCESS:{color} +1 6568 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1363/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1363/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1363/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12675979 - PreCommit-HIVE-TRUNK-Build

> PartitionPruner doesn't handle top level constant expression correctly
> ----------------------------------------------------------------------
>
>                 Key: HIVE-6934
>                 URL: https://issues.apache.org/jira/browse/HIVE-6934
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Harish Butani
>            Assignee: Hari Sankar Sivarama Subramaniyan
>            Priority: Critical
>             Fix For: 0.14.0
>
>         Attachments: HIVE-6934.4.patch, HIVE-6934.5.patch, HIVE-6934.6.patch, HIVE-6934.7.patch,
HIVE-6934.8.patch, HIVE-6934.9.patch, HIVE-6934.91.patch, HIVE-6934.92.patch
>
>
> You hit this error indirectly, because how we handle invalid constant comparisons. Consider:
> {code}
> create table x(key int, value string) partitioned by (dt int, ts string);
> -- both these queries hit this issue
> select * from x where key = 'abc';
> select * from x where dt = 'abc';
> -- the issue is the comparison get converted to the constant false
> -- and the PartitionPruner doesn't handle top level constant exprs corrcetly
> {code}
> Thanks to [~hsubramaniyan] for uncovering this as part of adding tests for HIVE-5376



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message