hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rui Li" <rui...@intel.com>
Subject Re: Review Request 27283: Compile time skew join optimization doesn't work with auto map join
Date Thu, 30 Oct 2014 08:47:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27283/
-----------------------------------------------------------

(Updated Oct. 30, 2014, 8:47 a.m.)


Review request for hive, Szehon Ho and Xuefu Zhang.


Bugs: HIVE-8610
    https://issues.apache.org/jira/browse/HIVE-8610


Repository: hive-git


Description
-------

This patch adds QBJoinTree and colExprMap for the cloned join operator tree in SkewJoinOptimizer,
so that CommonJoinResolver can properly convert the cloned join to map join.
The added tests are copied from skewjoinopt*.q, except that auto map join is enabled.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 273691e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java e87c41b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/JoinCond.java 96df830 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java 94c563f 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin10.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin11.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin5.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin6.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin7.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin8.q PRE-CREATION 
  ql/src/test/queries/clientpositive/skewjoin_mapjoin9.q PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin10.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin11.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin3.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin4.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin5.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin6.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin7.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin8.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/skewjoin_mapjoin9.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/27283/diff/


Testing
-------


Thanks,

Rui Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message