hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lefty Leverenz" <le...@hortonworks.com>
Subject Re: Review Request 25682: HIVE-6586 - Add new parameters to HiveConf.java after commit HIVE-6037
Date Mon, 27 Oct 2014 08:19:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25682/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 8:19 a.m.)


Review request for hive, Alan Gates, Navis Ryu, Prasad Mujumdar, and Sergey Shelukhin.


Bugs: HIVE-6586
    https://issues.apache.org/jira/browse/HIVE-6586


Repository: hive


Description (updated)
-------

HIVE-6586 kept track of new configuration parameters and changes to parameter descriptions
when HIVE-6037 moved parameter descriptions into HiveConf.java from hive-default.xml.template.

HIVE-6586.patch addresses all the fixes listed in the JIRA comments (except ones that had
already been fixed), tidies up some line breaks, and makes minor edits to parameter descriptions.
 It also revises the descriptions of hive.txn.xxx, hive.compactor.xxx, hive.server2.async.exec.shutdown.timeout,
and hive.security.authorization.createtable.owner.grants.

Patch 3:  HIVE-6586.3.patch omits minor edits and most of the line break changes, and addresses
Alan Gates' review suggestions.  For a complete list of changed parameter descriptions and
a generated hive-default.xml.template file for patch 3, see the JIRA.


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1634265 

Diff: https://reviews.apache.org/r/25682/diff/


Testing
-------

Generated hive-default.xml.template (attached to HIVE-6586) from the new HiveConf.java and
reviewed the changed parameter descriptions.


File Attachments
----------------

Patch 2, rebased and fixed some issues
  https://reviews.apache.org/media/uploaded/files/2014/10/01/8e4b539e-2590-4d8e-b3b5-45175a051f9d__HIVE-6586.2.patch


Thanks,

Lefty Leverenz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message