hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select
Date Wed, 22 Oct 2014 20:18:47 GMT


> On Oct. 22, 2014, 2:44 a.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 372
> > <https://reviews.apache.org/r/25550/diff/6/?file=726844#file726844line372>
> >
> >     Some tests reuses semanticanalyzer possibly from different threads.
> >     
> >     Its more defensive code than encountered problem.

I don't think semantic analyzer is used from multiple threads... given how it's organized
it would lead to disaster...
Anyway, there's no threads communicating via this variable, and boolean assignment is atomic,
so volatile should not be needed.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25550/#review57733
-----------------------------------------------------------


On Oct. 21, 2014, 1:13 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25550/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 1:13 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
dee7d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 37cbf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/ctas_colname.q 5322626 
>   ql/src/test/queries/clientpositive/decimal_serde.q cf3a86c 
>   ql/src/test/queries/clientpositive/insert0.q PRE-CREATION 
>   ql/src/test/results/clientpositive/ctas_colname.q.out 97dacf6 
>   ql/src/test/results/clientpositive/decimal_serde.q.out e461c2e 
>   ql/src/test/results/clientpositive/insert0.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message