hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 25550: HIVE-8021 CBO: support CTAS and insert ... select
Date Wed, 22 Oct 2014 20:18:41 GMT


> On Oct. 22, 2014, 6:48 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 12427
> > <https://reviews.apache.org/r/25550/diff/6/?file=726844#file726844line12427>
> >
> >     This seems wrong; because of this CBO wouldn't get excersised in verbose mode.
> >     
> >     Am i missing something?

it checks all the conditions in the first if, so this else if is only executed when CBO cannot
run. 
I will add comments


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25550/#review57857
-----------------------------------------------------------


On Oct. 21, 2014, 1:13 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25550/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 1:13 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java
dee7d7e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 37cbf7f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
>   ql/src/test/queries/clientpositive/cbo_correctness.q 4d8f156 
>   ql/src/test/queries/clientpositive/ctas_colname.q 5322626 
>   ql/src/test/queries/clientpositive/decimal_serde.q cf3a86c 
>   ql/src/test/queries/clientpositive/insert0.q PRE-CREATION 
>   ql/src/test/results/clientpositive/ctas_colname.q.out 97dacf6 
>   ql/src/test/results/clientpositive/decimal_serde.q.out e461c2e 
>   ql/src/test/results/clientpositive/insert0.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message