hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani" <rhbut...@gmail.com>
Subject Re: Review Request 26983: Fold is not null expr.
Date Wed, 22 Oct 2014 14:57:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26983/#review57794
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
<https://reviews.apache.org/r/26983/#comment98667>

    can you add a comment on this logic.


- Harish Butani


On Oct. 21, 2014, 4:58 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26983/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 4:58 p.m.)
> 
> 
> Review request for hive and Harish Butani.
> 
> 
> Bugs: HIVE-8531
>     https://issues.apache.org/jira/browse/HIVE-8531
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fold is not null expr.
> 
> 
> Diffs
> -----
> 
>   hbase-handler/src/test/results/positive/hbase_queries.q.out 1972236 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java 9ca194a

>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1b7a41d 
>   ql/src/test/results/clientpositive/auto_join11.q.out 3a4658a 
>   ql/src/test/results/clientpositive/auto_join12.q.out cf65a99 
>   ql/src/test/results/clientpositive/auto_join13.q.out cfdaebd 
>   ql/src/test/results/clientpositive/auto_join14.q.out addebe4 
>   ql/src/test/results/clientpositive/auto_join16.q.out ac0daa3 
>   ql/src/test/results/clientpositive/auto_join27.q.out 0fc7dd2 
>   ql/src/test/results/clientpositive/auto_join29.q.out 26ed0e8 
>   ql/src/test/results/clientpositive/auto_join_without_localtask.q.out 8762242 
>   ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 011f7bf 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 488fc50 
>   ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 95b264f 
>   ql/src/test/results/clientpositive/cluster.q.out 5808c74 
>   ql/src/test/results/clientpositive/constprog2.q.out 50ff890 
>   ql/src/test/results/clientpositive/correlationoptimizer10.q.out 27c573b 
>   ql/src/test/results/clientpositive/correlationoptimizer13.q.out f2a217b 
>   ql/src/test/results/clientpositive/correlationoptimizer8.q.out 9e34fe1 
>   ql/src/test/results/clientpositive/correlationoptimizer9.q.out 38da3c3 
>   ql/src/test/results/clientpositive/decimal_udf.q.out 8fda14c 
>   ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out c545506 
>   ql/src/test/results/clientpositive/index_auto_mult_tables.q.out e5dbf7b 
>   ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out 5f767e1 
>   ql/src/test/results/clientpositive/join11.q.out 3c8e742 
>   ql/src/test/results/clientpositive/join12.q.out 860565e 
>   ql/src/test/results/clientpositive/join13.q.out 753e292 
>   ql/src/test/results/clientpositive/join14.q.out 4d4f3e0 
>   ql/src/test/results/clientpositive/join16.q.out 8463837 
>   ql/src/test/results/clientpositive/join34.q.out 20038d7 
>   ql/src/test/results/clientpositive/join35.q.out 1822f2e 
>   ql/src/test/results/clientpositive/join38.q.out a8a0603 
>   ql/src/test/results/clientpositive/join_vc.q.out 58e1450 
>   ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out 79f334c 
>   ql/src/test/results/clientpositive/orc_predicate_pushdown.q.out bc8d242 
>   ql/src/test/results/clientpositive/ppd2.q.out 64fe191 
>   ql/src/test/results/clientpositive/ppd_clusterby.q.out 7b1abdd 
>   ql/src/test/results/clientpositive/ppd_gby_join.q.out a9d8491 
>   ql/src/test/results/clientpositive/ppd_join.q.out a689b09 
>   ql/src/test/results/clientpositive/ppd_join2.q.out 39c48be 
>   ql/src/test/results/clientpositive/ppd_join3.q.out fb4b306 
>   ql/src/test/results/clientpositive/ppd_join4.q.out c995f60 
>   ql/src/test/results/clientpositive/ppd_random.q.out 9463fd8 
>   ql/src/test/results/clientpositive/regex_col.q.out c42ba66 
>   ql/src/test/results/clientpositive/sample8.q.out e647d05 
>   ql/src/test/results/clientpositive/semijoin.q.out a9a9b86 
>   ql/src/test/results/clientpositive/skewjoin.q.out 4b30708 
>   ql/src/test/results/clientpositive/smb_mapjoin_14.q.out 05f5e00 
>   ql/src/test/results/clientpositive/smb_mapjoin_25.q.out 140c46c 
>   ql/src/test/results/clientpositive/smb_mapjoin_6.q.out 17e3d87 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_1.q.out 539f247 
>   ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out b594325 
>   ql/src/test/results/clientpositive/subquery_exists.q.out b7f4cb9 
>   ql/src/test/results/clientpositive/subquery_in.q.out 769beda 
>   ql/src/test/results/clientpositive/subquery_in_having.q.out ca3513e 
>   ql/src/test/results/clientpositive/subquery_multiinsert.q.out ebd47ca 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 273037a 
>   ql/src/test/results/clientpositive/subquery_views.q.out 50a5e29 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_10.q.out d661eef 
>   ql/src/test/results/clientpositive/tez/auto_sortmerge_join_9.q.out 571ea0a 
>   ql/src/test/results/clientpositive/tez/bucket_map_join_tez2.q.out a538839 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning.q.out 7a4c23d 
>   ql/src/test/results/clientpositive/tez/dynamic_partition_pruning_2.q.out 0624822 
>   ql/src/test/results/clientpositive/tez/filter_join_breaktask.q.out b94ffe2 
>   ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out 2a3e56c 
>   ql/src/test/results/clientpositive/tez/subquery_exists.q.out c79b718 
>   ql/src/test/results/clientpositive/tez/subquery_in.q.out d983c11 
>   ql/src/test/results/clientpositive/tez/vectorized_dynamic_partition_pruning.q.out 7e18711

>   ql/src/test/results/clientpositive/union20.q.out d66c7a6 
>   ql/src/test/results/clientpositive/union24.q.out 77ae018 
>   ql/src/test/results/clientpositive/union27.q.out da37707 
>   ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out d9eb311 
> 
> Diff: https://reviews.apache.org/r/26983/diff/
> 
> 
> Testing
> -------
> 
> Existing tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message