hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin" <ser...@hortonworks.com>
Subject Re: Review Request 26891: Fix CBO to use indexes when GenericUDFBridge is applied
Date Fri, 17 Oct 2014 23:13:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26891/#review57243
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java
<https://reviews.apache.org/r/26891/#comment97789>

    this check is gone... I wonder if it would be valid if user did add some UDF to only one
side? Maybe it should look at casts specifically


- Sergey Shelukhin


On Oct. 17, 2014, 9:19 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26891/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 9:19 p.m.)
> 
> 
> Review request for hive and Sergey Shelukhin.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> previous https://issues.apache.org/jira/browse/HIVE-8389 assumes that
> we have predicate: ((UDFToDouble(key) > UDFToDouble(80)) and (UDFToDouble(key) <
UDFToDouble(100))) for example.
> This does not work for the case when we have predicate: ((UDFToDouble(key) > 80.0)
and (UDFToDouble(key) < 100.0))
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 4987f7a 
> 
> Diff: https://reviews.apache.org/r/26891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message